Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log.md #4111

Merged
merged 14 commits into from
Sep 26, 2023
Merged

Update log.md #4111

merged 14 commits into from
Sep 26, 2023

Conversation

patkearns10
Copy link
Contributor

What are you changing in this pull request and why?

Source github URL currently brings me to the wrong place. Presumably these line numbers will change anytime someone commits to this file, so might need a better solution in the future to reference this code.
Screenshot 2023-09-22 at 10 28 16 AM

Change to L549-L566

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@patkearns10
Update log.md
7fd86bb 
Source github URL currently brings me to the wrong place.
Presumably these line numbers will change anytime someone commits to this file, so might need a better solution in the future to reference this code.
@patkearns10 patkearns10 requested a review from a team as a code owner September 22, 2023 02:30
@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 9:32am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 22, 2023
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Sep 25, 2023
mirnawong1
mirnawong1 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @patkearns10 ! thanks so much and love your contribution! i made a tweak and added a toggle to house the source code. will get this merged for you!

Screenshot 2023-09-26 at 10 22 09

@mirnawong1 mirnawong1 merged commit 0c7b0cc into current Sep 26, 2023
@mirnawong1 mirnawong1 deleted the patkearns10-log-macro branch September 26, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patkearns10 @mirnawong1