Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update builtins.md #4108

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Update builtins.md #4108

merged 4 commits into from
Sep 25, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Sep 22, 2023 •
edited
Loading

Preview

What are you changing in this pull request and why?

builtins is a variable rather than a function. But it does contain references to the builtin dbt context methods:

Checklist

@dbeatty10 dbeatty10 requested a review from a team as a code owner September 22, 2023 01:58
@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Sep 25, 2023 9:24am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 22, 2023
mirnawong1
mirnawong1 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1
Copy link
Contributor

nonblocker quesiton @dbeatty10 - does builtins.ref() function need to say variable or function? prob function because ref in involved? added it as a comment in the deploy preview

Screenshot 2023-09-22 at 17 25 04

@mirnawong1 mirnawong1 merged commit 2682f2b into current Sep 25, 2023
@mirnawong1 mirnawong1 deleted the dbeatty/builtins-context-variable branch September 25, 2023 09:50
@dbeatty10
Copy link
Contributor Author

does builtins.ref() function need to say variable or function? prob function because ref in involved?

yep, function 👍

Thanks for reviewing and deploying this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1