Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update groups attribute name for google SAML config #4106

Conversation

robotmiller
Copy link
Contributor

What are you changing in this pull request and why?

Google's docs say MemberOf so that's likely why we had it this way, but this value is the actual attribute name in the SAML response so we want it to be called groups.

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

@robotmiller robotmiller requested a review from BrJan September 21, 2023 16:26
@robotmiller robotmiller requested a review from a team as a code owner September 21, 2023 16:26
@welcome
Copy link

welcome bot commented Sep 21, 2023

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

@vercel
Copy link

vercel bot commented Sep 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 2:23pm

@github-actions github-actions bot added new contributor Label for first-time contributors content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 21, 2023
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 merged commit ddf178c into current Sep 25, 2023
7 checks passed
@mirnawong1 mirnawong1 deleted the ENTERPRISE-84-end-user-saml-sso-using-google-idp-should-get-group-membership branch September 25, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants