Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted link colors and added underlines on dark mode #4089

Closed
wants to merge 11 commits into from

Conversation

breezyfasano
Copy link
Member

@breezyfasano breezyfasano commented Sep 18, 2023

What are you changing in this pull request and why?

Preview Links

the following are different links from various pages on dbt docs. Switch over to dark mode and confirm if all links in the page body are accessible/white.

Checklist

  • Assure that there are no conflicts in the navbar or footer

@vercel
Copy link

vercel bot commented Sep 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 7:57pm

@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Sep 18, 2023
@breezyfasano breezyfasano marked this pull request as ready for review September 18, 2023 19:19
@breezyfasano breezyfasano requested a review from a team as a code owner September 18, 2023 19:19
@JKarlavige
Copy link
Collaborator

JKarlavige commented Sep 18, 2023

Hey @breezyfasano, for this task I believe @mirnawong1 is referencing the code-formatted text on the pages. For example in the page shared in the task, there is a piece of code-formatted text which is a part of a link. The code remains white, while the rest of the link is green.

If that is the case, I believe we'll want to keep the standard links green in dark mode, and just edit the code-formatted text for when they are links.

image

@mirnawong1
Copy link
Contributor

mirnawong1 commented Sep 19, 2023

hey @breezyfasano @JKarlavige ! i believe Jason K is right -- apologies if my task wasn't clear 🙈

in dark mode, the code text doesn't change color when it's hyperlinked - it just looks the same as a non linked code text. this makes it harder to know if the code text is a link or not. also it means documentarians sometimes have to add an extra word just to make it clear that it's a link. (e.g. global_configs function

@mirnawong1 mirnawong1 closed this Sep 19, 2023
@mirnawong1 mirnawong1 reopened this Sep 19, 2023
@breezyfasano
Copy link
Member Author

Sorry @mirnawong1 and @JKarlavige that's on me, I totally misread the ticket 🤦 I'll get that updated soon. Thank you!

@breezyfasano
Copy link
Member Author

Closing this as I'm going to open a new PR with a new solution.

@breezyfasano breezyfasano deleted the bug/link-colors branch September 19, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants