-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted link colors and added underlines on dark mode #4089
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @breezyfasano, for this task I believe @mirnawong1 is referencing the code-formatted text on the pages. For example in the page shared in the task, there is a piece of code-formatted text which is a part of a link. The code remains white, while the rest of the link is green. If that is the case, I believe we'll want to keep the standard links green in dark mode, and just edit the code-formatted text for when they are links. |
hey @breezyfasano @JKarlavige ! i believe Jason K is right -- apologies if my task wasn't clear 🙈 in dark mode, the code text doesn't change color when it's hyperlinked - it just looks the same as a non linked code text. this makes it harder to know if the code text is a link or not. also it means documentarians sometimes have to add an extra word just to make it clear that it's a link. (e.g. |
Sorry @mirnawong1 and @JKarlavige that's on me, I totally misread the ticket 🤦 I'll get that updated soon. Thank you! |
Closing this as I'm going to open a new PR with a new solution. |
What are you changing in this pull request and why?
Preview Links
the following are different links from various pages on dbt docs. Switch over to dark mode and confirm if all links in the page body are accessible/white.
Checklist