Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for CI phase 3 #4088

Merged
merged 15 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
title: "Update: Improvements to dbt Cloud continuous integration"
description: "September 2023: Improved deletion of temporary schemas"
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved
sidebar_label: "Update: Improved deletion of temporary schemas"
tags: [Sept-2023, CI]
date: 2023-09-18
sidebar_position: 08
---

Temporary schemas are now being deleted (dropped) for all adapters (like Databricks), PrivateLink connections, and environment variables in connection strings.

dbt Labs has rearchitected how schema deletion works for [continuous integration (CI)](/docs/deploy/continuous-integration) runs. We created a new service to delete any schema with a prefix of `dbt_cloud_pr_` that's been generated by a PR run.

However, temporary schemas will not be automatically deleted if:
- Your project overrides the `generate_schema_name` macro but it doesn't contain the prefix `dbt_cloud_pr_`.
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved
- You're using a [non-native Git integration](/docs/deploy/ci-jobs#trigger-a-ci-job-with-the-api). This is because automatic deletion relies on incoming webhooks from Git providers, which is only available through the native integrations.
47 changes: 12 additions & 35 deletions website/docs/docs/deploy/ci-jobs.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,20 @@ The green checkmark means the dbt build and tests were successful. Clicking on t

If you're experiencing any issues, review some of the common questions and answers below.

<details>
<summary>Temporary schemas aren't dropping</summary>
<div>
<div>If your temporary schemas aren't dropping after a PR merges or closes, this typically indicates you have overriden the <code>generate_schema_name</code> macro and it isn't using <code>dbt_cloud_pr_</code> as the prefix. To resolve this, change your macro so that the temporary PR schema name contains the required prefix. For example:
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved
<br></br>
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved
• ✅ Temporary PR schema name contains the prefix <code>dbt_cloud_pr_</code> (like <code>dbt_cloud_pr_123_456_marketing</code>) <br></br>
• ❌ Temporary PR schema name doesn't contain the prefix <code>dbt_cloud_pr_</code> (like <code>marketing</code>). <br></br>
</div>
</div>
</details>
<details>
<summary>Reconnecting your dbt project to use dbt Cloud's native integration with GitHub, GitLab, or Azure DevOps</summary>
<div>
<div>If your dbt project relies the generic git clone method that clones using SSH and deploy keys to connect to your dbt repo, you need to disconnect your repo and reconnect it using the native GitHub, GitLab, or Azure DevOps integration in order to enable dbt Cloud Slim CI.<br></br><br></br>
<div>If your dbt project relies the generic git clone method that clones using SSH and deploy keys to connect to your dbt repo, you need to disconnect your repo and reconnect it using the native GitHub, GitLab, or Azure DevOps integration in order to enable dbt Cloud CI.<br></br><br></br>
First, make sure you have the <a href="https://docs.getdbt.com/docs/cloud/git/connect-github">native GitHub authentication</a>, <a href="https://docs.getdbt.com/docs/cloud/git/connect-gitlab">native GitLab authentication</a>, or <a href="https://docs.getdbt.com/docs/cloud/git/connect-azure-devops">native Azure DevOps authentication</a> set up depending on which git provider you use. After you have gone through those steps, go to <strong>Account Settings</strong>, select <strong>Projects</strong> and click on the project you'd like to reconnect through native GitHub, GitLab, or Azure DevOps auth. Then click on the repository link.<br></br><br></br>

Once you're in the repository page, select <strong>Edit</strong> and then <strong>Disconnect Repository</strong> at the bottom.<br></br>
Expand All @@ -119,7 +129,7 @@ If you're experiencing any issues, review some of the common questions and answe
<details>
<summary>Production job runs failing at the <b>Clone Git Repository</b> step</summary>
<div>
<div>dbt Cloud can only checkout commits that belong to the original repository. dbt Cloud _cannot_ checkout commits that belong to a fork of that repository.<br></br><br></br>
<div>dbt Cloud can only check out commits that belong to the original repository. dbt Cloud <i>cannot</i> checkout commits that belong to a fork of that repository.<br></br><br></br>

If you receive the following error message at the <b>Clone Git Repository</b> step of your job run:<br></br>
<code>
Expand All @@ -144,39 +154,6 @@ If you're experiencing any issues, review some of the common questions and answe
</div>
</details>

### Temp PR schema limitations

If your temporary pull request schemas aren't dropping after a merge or close of the PR, it's likely due to the below scenarios. Open and review the toggles below for recommendations on how to resolve this:
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved

<details>
<summary>You used dbt Cloud environment variables in your connection settings page </summary>
<div>
<div>To resolve this, remove environment variables in your <a href="https://docs.getdbt.com/docs/dbt-cloud/using-dbt-cloud/cloud-environment-variables">connections settings</a>.</div>
</div>
</details>
<details>
<summary>You have an empty/blank default schema</summary>
<div>
<div>To change this, edit and fill in your default schema.</div>
</div>
</details>
<details>
<summary>You have overridden the <code>generate_schema_name</code> macro</summary>
<div>
<div>To resolve this, change your macro so that the temporary PR schema name contains the default prefix and review the guidance below:
<br></br>
• ✅ Temporary PR schema name contains the prefix <code>dbt_cloud_pr_</code> (like <code>dbt_cloud_pr_123_456_marketing</code>) <br></br>
• ❌ Temporary PR schema name doesn't contain the prefix <code>dbt_cloud_pr_</code> (like <code>marketing</code>). <br></br>
</div>
</div>
</details>
<details>
<summary>You have overridden the <code>generate_database_name</code> macro</summary>
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved
<div>
<div>If you assume that the project's default connection is to a database named <code>analytics</code>, review the guidance below to resolve this:
<br></br>
• ✅ Database remains the same as the connection default (like <code>analytics</code>) <br></br>
• ❌ Database has changed from the default connection (like <code>dev</code>). <br></br>
</div>
</div>
</details>
2 changes: 1 addition & 1 deletion website/docs/docs/deploy/continuous-integration.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dbt Cloud builds and tests the models affected by the code change in a temporary

When the CI run completes, you can view the run status directly from within the pull request. dbt Cloud updates the pull request in GitHub, GitLab, or Azure DevOps with a status message indicating the results of the run. The status message states whether the models and tests ran successfully or not.

dbt Cloud deletes the temporary schema from your <Term id="data-warehouse" /> when you close or merge the pull request. If your project has database or schema customization using the [generate_database_name](/docs/build/custom-databases#generate_database_name) or [generate_schema_name](/docs/build/custom-schemas#how-does-dbt-generate-a-models-schema-name) macros, dbt Cloud might not drop the temporary schema from your data warehouse. For more information, refer to [Temp PR schema limitations](/docs/deploy/ci-jobs#temp-pr-schema-limitations).
dbt Cloud deletes the temporary schema from your <Term id="data-warehouse" /> when you close or merge the pull request. If your project has schema customization using the [generate_schema_name](/docs/build/custom-schemas#how-does-dbt-generate-a-models-schema-name) macro, dbt Cloud might not drop the temporary schema from your data warehouse. For more information, refer to [Troubleshooting](/docs/deploy/ci-jobs#troubleshooting).
nghi-ly marked this conversation as resolved.
Show resolved Hide resolved

## Differences between CI jobs and other deployment jobs

Expand Down
Loading