Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove beta tabs/callouts for CI phase 2 #4074

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 13, 2023

What are you changing in this pull request and why?

For the CI phase 2 GA, remove related beta callouts and beta tabs

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner September 13, 2023 21:43
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2023 10:06pm

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit a6694b5
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/650230dbb222770008f6fc2d
😎 Deploy Preview https://deploy-preview-4074--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Sep 13, 2023
…dbt-labs/docs.getdbt.com into ly-docs-remove-beta-callouts-ci-phase-2
Copy link
Contributor

@thorn14 thorn14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

We may need to add some additional notes or recommendations but I do not believe that should ultimately be a blocker here.

@nghi-ly nghi-ly merged commit 86a4655 into current Sep 13, 2023
@nghi-ly nghi-ly deleted the ly-docs-remove-beta-callouts-ci-phase-2 branch September 13, 2023 22:51
@mirnawong1 mirnawong1 mentioned this pull request Sep 15, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants