Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the two ways of authentication to the SSO config section #4069

Merged
merged 6 commits into from
Sep 14, 2023

Conversation

Tonayya
Copy link
Contributor

@Tonayya Tonayya commented Sep 13, 2023

There's two ways of either using externalbrowser or native okta (okta URL), just added relevant fields and stuff. Relevant conversation in this slack thread

What are you changing in this pull request and why?

Checklist

  • Review the Content style guide and About versioning so my content adheres to these guidelines.
  • Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):

  • Add page to website/sidebars.js
  • Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):

  • Remove page from website/sidebars.js
  • Add an entry website/static/_redirects
  • Ran link testing to update the links that point to the deleted page

Sorry, something went wrong.

There's two ways of either using `externalbrowser` or native okta (okta URL), just added relevant fields and stuff. Relevant conversation in [this slack thread](https://dbt-labs.slack.com/archives/C05FWBP9X1U/p1694385604291469)
@Tonayya Tonayya requested a review from a team as a code owner September 13, 2023 04:09
@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for docs-getdbt-com ready!

Name Link
🔨 Latest commit e7df4c3
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6502c0233811b10008da4051
😎 Deploy Preview https://deploy-preview-4069--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Sep 13, 2023
@vercel
Copy link

vercel bot commented Sep 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:17am

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Tonayya , great addition -- thank you so much for taking the user's feedback and adding this to our docs ✨ I've made some tweaks, mostly presenting the two options (externalbrowser and okta URL) using tabs.

let me know what you think and if you're happy with it - i'll get this merged for you and you can even let the user know the pr was merged so they can see how useful their feedback was!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants