-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify macro properties aren't supported in dbt_project.yml #3989
Merged
Merged
Changes from 13 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
0a8b4bf
clarify macro aren't support in project.yml file
mirnawong1 907fde4
Merge branch 'current' into mwong-macro-yml
mirnawong1 cda991a
add snippet and rephrase
mirnawong1 66ff1df
Update dbt_project.yml.md
mirnawong1 293e437
Merge branch 'current' into mwong-macro-yml
mirnawong1 b163c5b
Update website/docs/reference/macro-properties.md
mirnawong1 ddd2c63
Update website/docs/reference/macro-properties.md
mirnawong1 237f6da
Merge branch 'mwong-macro-yml' of https://github.com/dbt-labs/docs.ge…
mirnawong1 6d8ce4e
update lang
mirnawong1 0b5a949
Merge branch 'current' into mwong-macro-yml
mirnawong1 49d7b63
Merge branch 'current' into mwong-macro-yml
mirnawong1 9a9627a
tweak snippet and add versionblock
mirnawong1 a56d9a8
remove break
mirnawong1 db04b02
Merge branch 'current' into mwong-macro-yml
mirnawong1 3d8dbd6
Merge branch 'current' into mwong-macro-yml
mirnawong1 d22b7e9
Merge branch 'current' into mwong-macro-yml
mirnawong1 a24c149
Merge branch 'current' into mwong-macro-yml
mirnawong1 b01215a
Merge branch 'current' into mwong-macro-yml
mirnawong1 d5c881f
Merge branch 'current' into mwong-macro-yml
mirnawong1 a453e7a
Merge branch 'current' into mwong-macro-yml
mirnawong1 f4ccb57
Merge branch 'current' into mwong-macro-yml
mirnawong1 30c7c4d
Merge branch 'current' into mwong-macro-yml
mirnawong1 02fb137
adding jerco's great feedback
mirnawong1 1872ce1
clarify
mirnawong1 56fbe0a
change yaml to `properties.yml`
mirnawong1 75b1457
Merge branch 'current' into mwong-macro-yml
mirnawong1 b5e6f28
Merge branch 'current' into mwong-macro-yml
mirnawong1 5ec1c05
add table
mirnawong1 95b430d
Merge branch 'current' into mwong-macro-yml
mirnawong1 ef8c3bc
Update configs-and-properties.md
mirnawong1 06740f1
Merge branch 'current' into mwong-macro-yml
mirnawong1 02a3cae
Remove trailing space
dbeatty10 fa206ce
Merge branch 'current' into mwong-macro-yml
dbeatty10 f353599
Merge branch 'current' into mwong-macro-yml
dbeatty10 29c32df
Merge branch 'current' into mwong-macro-yml
mirnawong1 6c4a0c6
Merge branch 'current' into mwong-macro-yml
dbeatty10 5baf269
Merge branch 'current' into mwong-macro-yml
mirnawong1 ca47c06
Merge branch 'current' into mwong-macro-yml
mirnawong1 e332c34
Merge branch 'current' into mwong-macro-yml
mirnawong1 a1a8e7f
Update docs.md
mirnawong1 169f759
Merge branch 'current' into mwong-macro-yml
mirnawong1 e27bb9d
Merge branch 'current' into mwong-macro-yml
dbeatty10 7ad36fd
Update dbt_project.yml.md
dbeatty10 c26bc39
Remove extra newline
dbeatty10 9225af1
Merge branch 'current' into mwong-macro-yml
mirnawong1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
<span>This is because you can set "configs" for many resources in <code>dbt_project.yml</code>, while you can only set "properties" one resource at a time. Since {props.title} are "properties", this means you cannot configure it from <code>dbt_project.yml</code></span>. Refer to <a href="https://docs.getdbt.com/reference/configs-and-properties#which-properties-are-not-also-configs" target="_self"> Configs and properties</a> for more info. | ||
mirnawong1 marked this conversation as resolved.
Show resolved
Hide resolved
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change in v1.7:
Update: I've reread this now, across a few other pages, and I now get your point. You're saying: "You can define properties for sources/models/metrics/etc in a YAML file. You can also configure a number of these resources at once in
dbt_project.yml
. But you cannot actually define their properties withindbt_project.yml
, even though it is also a YAML file associated with your project." (The same holds for a few other "special" YAML files:selectors.yml
,packages.yml
/dependencies.yml
,profiles.yml
, ...)I found this confusing on the first read. I'm trying to think of what else we could do to resolve this ambiguity.
It feels like what we really need is a standard name for the kind of yaml file where these things can be defined. I think we've informally settled on something like "properties yaml file":
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha, thanks so much and apologies for the confusion! you've summarized my understanding totally right and i think you're right about the standard name -- I'll change it to
properties.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok clarified this by updating the partial:
<span>{props.title} are "special properties" in that you can't configure them in the <code>dbt_project.yml</code> file or using <code>config()</code> blocks. Refer to <a href="https://docs.getdbt.com/reference/configs-and-properties#which-properties-are-not-also-configs" target="_self"> Configs and properties</a> for more info.</span>
which turns content into: