Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support kms_key_name feature for snapshots and seeds #1482

Conversation

b0lle
Copy link

@b0lle b0lle commented May 25, 2022

Description & motivation

I have added kms_key_name support for seeds in #193 bigquery-adapter

To-do before merge

@b0lle b0lle requested review from annafil and runleonarun as code owners May 25, 2022 20:54
@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for docs-getdbt-com ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 77f2e22
🔍 Latest deploy log https://app.netlify.com/sites/docs-getdbt-com/deploys/6387502b8e8cc60009378750
😎 Deploy Preview https://deploy-preview-1482--docs-getdbt-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels May 25, 2022
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: x-small This change will take under 3 hours to fix. labels May 27, 2022
@b0lle b0lle force-pushed the fix/kms_key_name_for_snapshots_and_seeds_supported branch from d8f1f7d to a3f6aa1 Compare May 28, 2022 13:19
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: x-small This change will take under 3 hours to fix. labels May 28, 2022
@mirnawong1 mirnawong1 requested a review from dataders as a code owner November 30, 2022 12:44
@matthewshaver matthewshaver requested a review from a team as a code owner October 18, 2023 20:37
@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 8:44pm

@matthewshaver
Copy link
Contributor

Closing due to age and the adapter PR still being open. Added the user docs tag to dbt-labs/dbt-bigquery#193 so we can address this once that is merged (no movement since June 2023).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants