Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Removing a contracted model now constitutes a breaking change #5574

Closed
FishtownBuildBot opened this issue May 28, 2024 · 2 comments · Fixed by #6119
Closed

[Core] Removing a contracted model now constitutes a breaking change #5574

FishtownBuildBot opened this issue May 28, 2024 · 2 comments · Fixed by #6119
Assignees
@runleonarun @jtcohen6 @graciegoheen @dave-connors-3
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear size: small This change will take 1 to 2 days to address

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented May 28, 2024 •
edited by dbeatty10
Loading

Removing a contracted model now constitutes a breaking change:

  • if the model is versioned -> error
  • if the model is unversioned -> warning

A model is considered 'removed' if it is deleted, renamed, or disabled (via config: enabled)

Updating the docs here would make sense! https://docs.getdbt.com/docs/collaborate/govern/model-contracts#how-are-breaking-changes-handled

Issue: dbt-labs/dbt-core#10116
Pull request: dbt-labs/dbt-core#10221
@FishtownBuildBot FishtownBuildBot mentioned this issue May 28, 2024
Closed
2 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels May 28, 2024
@nataliefiann nataliefiann added the size: small This change will take 1 to 2 days to address label Sep 10, 2024
@nghi-ly nghi-ly changed the title Docs Changes Needed from dbt-core Issue #10116 [Core] Docs Changes Needed from dbt-core Issue #10116 Sep 13, 2024
@nataliefiann
Copy link
Contributor

Hiya @jtcohen6

Happy Monday - I hope you're well.

Just so I have an understanding here, can you let me know what you'd like updating on this please?

Kind Regards
Natalie

@runleonarun
Copy link
Collaborator

I can grab this one and open a PR, Natalie! Looks like model contracts have a breaking change that needs to be added to the list.

@graciegoheen graciegoheen changed the title [Core] Docs Changes Needed from dbt-core Issue #10116 [Core] dbt-core Issue #10116 - Removing a contracted model now constitutes a breaking change Sep 23, 2024
@runleonarun runleonarun mentioned this issue Sep 23, 2024
Merged
3 tasks
@mirnawong1 mirnawong1 mentioned this issue Sep 24, 2024
Closed
3 tasks
@dbeatty10 dbeatty10 changed the title [Core] dbt-core Issue #10116 - Removing a contracted model now constitutes a breaking change [Core] Removing a contracted model now constitutes a breaking change Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runleonarun runleonarun

@jtcohen6 jtcohen6

@graciegoheen graciegoheen

@dave-connors-3 dave-connors-3

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.9 improvement Use this when an area of the docs needs improvement as it's currently unclear size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated breaking changes section dbt-labs/docs.getdbt.com
7 participants
@runleonarun @jtcohen6 @graciegoheen @dave-connors-3 @FishtownBuildBot @nghi-ly @nataliefiann