Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit testing known exception - can't unit test join logic that doesn't have aliases #5418

Closed
1 task
graciegoheen opened this issue May 1, 2024 · 0 comments · Fixed by #5460
Closed
1 task

unit testing known exception - can't unit test join logic that doesn't have aliases #5418

graciegoheen opened this issue May 1, 2024 · 0 comments · Fixed by #5460
Assignees
@nghi-ly
Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear unit testing docs for 1.8 unit testing
Milestone
dbt Core v1.8 Doc...

Comments

@graciegoheen
Copy link
Collaborator

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

Update unit testing docs to call out this known exception

See dbt-labs/dbt-core#10068

What part(s) of the page would you like to see updated?

Similar to #5353

I'm actually wondering if it may be best to have a page of known exceptions? To not clutter the "before you begin" section

Additional information

No response
@graciegoheen graciegoheen added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt-core v1.8 unit testing docs for 1.8 unit testing labels May 1, 2024
@graciegoheen graciegoheen mentioned this issue May 1, 2024
Closed
2 tasks
@nghi-ly nghi-ly self-assigned this May 2, 2024
@nghi-ly nghi-ly mentioned this issue May 7, 2024
Merged
3 tasks
nghi-ly added a commit that referenced this issue May 7, 2024
@nghi-ly
Table aliases needed to unit test joins (#5460)
c114420 
## What are you changing in this pull request and why?

To unit test `join` logic, need to use table aliases. 

closes #5418 

## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [x] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Needs review from PM
@dbeatty10 dbeatty10 mentioned this issue Dec 6, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghi-ly nghi-ly

Labels
content Improvements or additions to content dbt-core v1.8 improvement Use this when an area of the docs needs improvement as it's currently unclear unit testing docs for 1.8 unit testing
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

Table aliases needed to unit test joins dbt-labs/docs.getdbt.com
2 participants
@graciegoheen @nghi-ly