Skip to content

Commit

Permalink
fix typo and re-format sql (#4774)
Browse files Browse the repository at this point in the history
This PR fixes a typo and re-formats the example SQL.
  • Loading branch information
mirnawong1 authored Jan 23, 2024
2 parents d5e43da + 1552877 commit 8ead06e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions website/docs/docs/build/conversion-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ inner join (
select *, uuid_string() as uuid from buys -- Adds a uuid column to uniquely identify the different rows
) b
on
v.user_id = b.user_id and v.ds <= b.ds and v.ds > b.ds - interval '7 day'
v.user_id = b.user_id and v.ds <= b.ds and v.ds > b.ds - interval '7 days'
```

The dataset returns the following (note that there are two potential conversion events for the first visit):
Expand Down Expand Up @@ -147,7 +147,6 @@ inner join (
) b
on
v.user_id = b.user_id and v.ds <= b.ds and v.ds > b.ds - interval '7 day'
```

The dataset returns the following:
Expand Down Expand Up @@ -249,7 +248,7 @@ Use the following additional settings to customize your conversion metrics:
To return zero in the final data set, you can set the value of a null conversion event to zero instead of null. You can add the `fill_nulls_with` parameter to your conversion metric definition like this:

```yaml
- name: vist_to_buy_conversion_rate_7_day_window
- name: visit_to_buy_conversion_rate_7_day_window
description: "Conversion rate from viewing a page to making a purchase"
type: conversion
label: Visit to Seller Conversion Rate (7 day window)
Expand Down Expand Up @@ -345,7 +344,6 @@ on
and v.ds <= buy_source.ds
and v.ds > buy_source.ds - interval '7 day'
and buy_source.product_id = v.product_id --Joining on the constant property product_id
```

</TabItem>
Expand Down

0 comments on commit 8ead06e

Please sign in to comment.