Skip to content

Commit

Permalink
Clean up the example of sql to metricflow (#5611)
Browse files Browse the repository at this point in the history
Making everything consistent in the example. It referenced returning
customers but had a new customers = true.

## What are you changing in this pull request and why?
<!---
Describe your changes and why you're making them. If related to an open 
issue or a pull request on dbt Core, then link to them here! 

To learn more about the writing conventions used in the dbt Labs docs,
see the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md).
-->

## Checklist
<!--
Uncomment when publishing docs for a prerelease version of dbt:
- [ ] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade)
-->
- [ ] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/vercel.json`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
  • Loading branch information
mirnawong1 authored Jun 5, 2024
2 parents 4fd71ca + 8a4a0c3 commit 11e0293
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions website/docs/docs/build/about-metricflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,15 @@ MetricFlow simplifies the SQL process via metric YAML configurations as seen bel

```yaml
metrics:
- name: food_order_pct_of_order_total
description: Revenue from food orders in each store
- name: food_order_pct_of_order_total_returning
description: Revenue from food orders from returning customers
label: "Food % of Order Total"
type: ratio
type_params:
numerator: food_order
denominator: active_customers
denominator: order_total
filter: |
{{ Dimension('customer__is_new_customer')}} = true
{{ Dimension('customer__is_new_customer') }} = false
```
</TabItem>
</Tabs>
Expand Down

0 comments on commit 11e0293

Please sign in to comment.