Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tests: -> data_tests: in README.md #945

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

syou6162
Copy link

@syou6162 syou6162 commented Sep 2, 2024

resolves #894

Problem

Solution

  • I updated tests: -> data_tests: in README.md

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the README.md (if applicable)

@syou6162 syou6162 marked this pull request as ready for review September 2, 2024 07:15
@syou6162
Copy link
Author

syou6162 commented Sep 5, 2024

@dbeatty10 Could you review this pull request?

Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like #893 intentionally only changed the integration_tests folder in order for it to be a non-breaking change.

So I think we're going to leave the documentation as-is.

If we did choose to merge this change, it would need to be data_tests: (underscore!) rather than data-tests:.

@syou6162
Copy link
Author

syou6162 commented Sep 5, 2024

@dbeatty10 Thank you for your response. I have corrected data-tests: to data_tests:.

According to the official documentation, tests: will continue to be supported, but dbt 1.8 and later will output a warning by default. I think that the number of users of dbt 1.8 and later will continue to increase, and versions prior to dbt 1.8 will reach the end of life support level on Nov 1, 2024. I think that dbt-labs would like to recommend data_tests:, and I think that data_tests: is appropriate as the documentation provided by dbt-labs.

@syou6162 syou6162 requested a review from dbeatty10 September 5, 2024 18:00
@dbeatty10
Copy link
Contributor

@dbeatty10 Thank you for your response. I have corrected data-tests: to data_tests:.

According to the official documentation, tests: will continue to be supported, but dbt 1.8 and later will output a warning by default.

Is avoiding the warning your primary concern here? Or alignment with the official documentation? It's okay if your main concern is both or something completely else too!

If it's the warning, we do have an open issue to cease raising a warning here: dbt-labs/dbt-core#10564. We'd probably update the official documentation at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated syntax of data tests within YAML
2 participants