Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the behavior of the incremental schema change ignore option to properly handle the scenario when columns are dropped #980

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fixed the behavior of the incremental schema change ignore option to properly handle the scenario when columns are dropped #980

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d8b28a
fix incremental schema change ignore
case-k-git Feb 11, 2024
f224fbd
fix macro
case-k-git Mar 6, 2024
6cba6ac
it
case-k-git Mar 6, 2024
bf04bed
Merge branch 'main' into feature/fix-incremental-column-deop-operation
case-k-git Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dbt/include/spark/macros/materializations/incremental/strategies.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,17 @@

{% macro get_insert_into_sql(source_relation, target_relation) %}

-- {%- set source_columns = adapter.get_columns_in_relation(source_relation) -%}
-- {%- set common_columns = [] -%}
-- {%- for dest_col in dest_columns -%}
-- {%- for source_col in source_columns -%}
-- {%- if dest_col.name == source_col.name -%}
-- {%- if common_columns.append(dest_col) -%}{%- endif -%}
-- {%- endif -%}
-- {%- endfor -%}
-- {%- endfor -%}
-- {%- set dest_cols_csv = common_columns | map(attribute='quoted') | join(', ') -%}
-- insert into table {{ target_relation }} ({{ dest_cols_csv }})
{%- set dest_columns = adapter.get_columns_in_relation(target_relation) -%}
{%- set dest_cols_csv = dest_columns | map(attribute='quoted') | join(', ') -%}
insert into table {{ target_relation }}
Expand Down
Loading