Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused invalid_insert_overwrite_delta_msg variable #963

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

dbeatty10
Copy link
Contributor

resolves #962

Problem

While researching dbt-labs/docs.getdbt.com#4639, it looks like this code is unused since #700.

Solution

Searching both dbt-spark and dbt-databricks didn't yield any other references to invalid_insert_overwrite_delta_msg:

So it appears safe to remove it altogether.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • Tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

@dbeatty10 dbeatty10 requested a review from a team as a code owner December 14, 2023 20:50
@cla-bot cla-bot bot added the cla:yes label Dec 14, 2023
Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're touching this, there's a part of me that really wants to move this entire macro into a python method which gets called in the macro. It's all logic and no templating. But I'm fine approving for the sake of brevity in changes.

@dbeatty10 dbeatty10 merged commit f774bcb into main Dec 14, 2023
22 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty/962-remove-unused-message branch December 14, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-1074] [Implementation] Remove invalid_insert_overwrite_delta_msg message
2 participants