Support new agate Integer type and test with empty seed #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide. |
leahwicz
approved these changes
Nov 7, 2023
mikealfare
added
the
backport 1.7.latest
github-actions bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
* Support new agate Integer type and test with empty seed * add changie, remove branch reference (cherry picked from commit 0f39bd1)
leahwicz
pushed a commit
that referenced
this pull request
Nov 7, 2023
* Support new agate Integer type and test with empty seed * add changie, remove branch reference (cherry picked from commit 0f39bd1) Co-authored-by: Gerda Shank <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Support new agate Integer type and test with empty seed * add changie, remove branch reference (cherry picked from commit 0f39bd1)
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Support new agate Integer type and test with empty seed * add changie, remove branch reference (cherry picked from commit 0f39bd1) Co-authored-by: Gerda Shank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #935
Problem
dbt Core added support for an agate integer type to support the show command. Empty seeds were failing due to lack of support in the "convert_" methods in impl.py, so a regression bug case fixed that.
Solution
Add a "convert_integer_type" method and include test of empty seed creation.
Checklist