Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist view column comments #893

Merged
merged 20 commits into from
Sep 26, 2023
Merged

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 25, 2023

taking over #866 to get it over the finish line.

  • persist view column comments
  • format: whitespace
  • extracted get_matched_column macro
  • move parenthesis to the calling macro
  • changelog
  • fix: remove matching column in different case
  • fix: remove get_matched_column macro - not much logic left there.
  • escape column comments and add functional test

resolves #372
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@colin-rogers-dbt colin-rogers-dbt self-assigned this Sep 25, 2023
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner September 25, 2023 18:43
@cla-bot cla-bot bot added the cla:yes label Sep 25, 2023
@colin-rogers-dbt
Copy link
Contributor Author

@benc-db I think I've incorporated your feedback but please take a look

@colin-rogers-dbt colin-rogers-dbt merged commit 1672efd into main Sep 26, 2023
21 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the persist_view_column_comments branch September 26, 2023 20:12
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
* persist view column comments

* format: whitespace

* extracted get_matched_column macro

* move parenthesis to the calling macro

* changelog

* fix: remove matching column in different case

* fix: remove get_matched_column  macro - not much logic left there.

* escape column comments and add functional test

* Update Features-20230817-130731.yaml

* remove unneeded f string

* add test fixture to view test

* fix fixtures for TestPersistDocsDeltaView

* fix fixtures for TestPersistDocsDeltaView

* formatting

* fix tests

---------

Co-authored-by: Juri Krainjukov <[email protected]>
(cherry picked from commit 1672efd)
github-actions bot pushed a commit that referenced this pull request Nov 3, 2023
* persist view column comments

* format: whitespace

* extracted get_matched_column macro

* move parenthesis to the calling macro

* changelog

* fix: remove matching column in different case

* fix: remove get_matched_column  macro - not much logic left there.

* escape column comments and add functional test

* Update Features-20230817-130731.yaml

* remove unneeded f string

* add test fixture to view test

* fix fixtures for TestPersistDocsDeltaView

* fix fixtures for TestPersistDocsDeltaView

* formatting

* fix tests

---------

Co-authored-by: Juri Krainjukov <[email protected]>
(cherry picked from commit 1672efd)
mikealfare pushed a commit that referenced this pull request Nov 9, 2023
* persist view column comments

* format: whitespace

* extracted get_matched_column macro

* move parenthesis to the calling macro

* changelog

* fix: remove matching column in different case

* fix: remove get_matched_column  macro - not much logic left there.

* escape column comments and add functional test

* Update Features-20230817-130731.yaml

* remove unneeded f string

* add test fixture to view test

* fix fixtures for TestPersistDocsDeltaView

* fix fixtures for TestPersistDocsDeltaView

* formatting

* fix tests

---------

Co-authored-by: Juri Krainjukov <[email protected]>
(cherry picked from commit 1672efd)

Co-authored-by: colin-rogers-dbt <[email protected]>
mikealfare added a commit that referenced this pull request Nov 30, 2023
* persist view column comments

* format: whitespace

* extracted get_matched_column macro

* move parenthesis to the calling macro

* changelog

* fix: remove matching column in different case

* fix: remove get_matched_column  macro - not much logic left there.

* escape column comments and add functional test

* Update Features-20230817-130731.yaml

* remove unneeded f string

* add test fixture to view test

* fix fixtures for TestPersistDocsDeltaView

* fix fixtures for TestPersistDocsDeltaView

* formatting

* fix tests

---------

Co-authored-by: Juri Krainjukov <[email protected]>
(cherry picked from commit 1672efd)

Co-authored-by: colin-rogers-dbt <[email protected]>
Co-authored-by: Mike Alfare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-764] Persist Column level comments when creating views
4 participants