Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 1.8.latest] Pin build dependencies to final releases #1129

Closed
wants to merge 6 commits into from
Closed

[Bug 1.8.latest] Pin build dependencies to final releases #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0fb509c
pin build dependencies to final releases
mikealfare Oct 23, 2024
9f11576
pin build dependencies to final releases
mikealfare Oct 23, 2024
e79b263
Cherry pick versioning from above to fix test
colin-rogers-dbt Oct 15, 2024
efbcb45
Try more dependencies
VersusFacit Oct 23, 2024
fca3b56
Other version attempt.
VersusFacit Oct 23, 2024
5bdc4d1
remove the koalas fixture.
VersusFacit Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20241023-105407.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Pin build dependencies to final releases
time: 2024-10-23T10:54:07.142933-04:00
custom:
Author: mikealfare
Issue: "1129"
6 changes: 3 additions & 3 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ def _get_plugin_version_dict():
include_package_data=True,
install_requires=[
"sqlparams>=3.0.0",
"dbt-common>=0.1.0a1,<2.0",
"dbt-adapters>=0.1.0a1,<2.0",
"dbt-common>=0.1.0,<2.0",
"dbt-adapters>=0.1.0,<2.0",
# add dbt-core to ensure backwards compatibility of installation, this is not a functional dependency
"dbt-core>=1.8.0a1",
"dbt-core>=1.8.0",
],
extras_require={
"ODBC": odbc_extras,
Expand Down
15 changes: 13 additions & 2 deletions tests/functional/adapter/test_python_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,12 @@
BasePythonModelTests,
BasePythonIncrementalTests,
)
from dbt.tests.adapter.python_model.test_spark import BasePySparkTests
from dbt.tests.adapter.python_model.test_spark import (
BasePySparkTests,
PANDAS_MODEL,
PANDAS_ON_SPARK_MODEL,
PYSPARK_MODEL,
)


@pytest.mark.skip_profile("apache_spark", "spark_session", "databricks_sql_endpoint")
Expand All @@ -15,7 +20,13 @@ class TestPythonModelSpark(BasePythonModelTests):

@pytest.mark.skip_profile("apache_spark", "spark_session", "databricks_sql_endpoint")
class TestPySpark(BasePySparkTests):
pass
@pytest.fixture(scope="class")
def models(self):
return {
"pandas_df.py": PANDAS_MODEL,
"pyspark_df.py": PYSPARK_MODEL,
"pandas_on_spark_df.py": PANDAS_ON_SPARK_MODEL,
}


@pytest.mark.skip_profile("apache_spark", "spark_session", "databricks_sql_endpoint")
Expand Down
Loading