Allow configuring snapshot column names #1097
Conversation
| @@ -126,7 +126,7 @@ | |||
| {{ run_hooks(pre_hooks, inside_transaction=True) }} | |||
|
|
|||
| {% set strategy_macro = strategy_dispatch(strategy_name) %} | |||
| {% set strategy = strategy_macro(model, "snapshotted_data", "source_data", config, target_relation_exists) %} | |||
| {% set strategy = strategy_macro(model, "snapshotted_data", "source_data", model['config'], target_relation_exists) %} | |||
There was a problem hiding this comment.
I don't think these are the same config. There's config in the globals, and then there's also config.model.config. Was there a bug or an issue that required this change?
There was a problem hiding this comment.
Yes. I'm not sure why somebody was using the passed in config to start with (I suspect it was because using defaults is different for the config object and the config dictionary that got passed in), but you can't get a "property" from the dictionary, only the config object that you get from the context.
dev-requirements.txt
Outdated
| @@ -2,7 +2,7 @@ | |||
| # TODO: how to automate switching from develop to version branches? | |||
| git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | |||
| git+https://github.com/dbt-labs/dbt-common.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git | |||
| git+https://github.com/dbt-labs/dbt-adapters.git@snapshot_column_names | |||
There was a problem hiding this comment.
Friendly reminder to swap back prior to merging.
| {{ adapter.valid_snapshot_target(target_relation) }} | ||
| {% set stcn = config.get("snapshot_table_column_names") or get_snapshot_table_column_names() %} | ||
|
|
||
| {{ adapter.valid_snapshot_target(target_relation, stcn) }} |
There was a problem hiding this comment.
Calling adapter.valid_snapshot_target with the new second parameter will break unless we use the new version of dbt-adapters. We need to bump the minor on dbt-adapters and then bump the pin in dbt-spark to this new minor.
resolves #1096
Problem
Support for dbt-labs/dbt-core#10608, configuring snapshot column names
Solution
Modify snapshot.sql to support changed column names.
Checklist