Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix incremental python tables - dbt can't find temporary table transaction logs #1042

Merged
merged 9 commits into from
May 14, 2024
Merged

[Bug] Fix incremental python tables - dbt can't find temporary table transaction logs #1042

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b33ad8a
unskip test
mikealfare May 9, 2024
735a382
align test pyodbc version with build deps; add pyspark from build deps
mikealfare May 9, 2024
dae47f4
align test pyodbc version with build deps; add pyspark from build deps
mikealfare May 9, 2024
ab9c767
revert change to exclude database and schema from temp relations
mikealfare May 13, 2024
35fb21c
Merge branch 'refs/heads/main' into bug/1033-incremental-python-model
mikealfare May 13, 2024
c13a334
changelog entry
mikealfare May 13, 2024
1d7f8a7
retain existing behavior for unit tests by vendoring temp relation in…
mikealfare May 13, 2024
f10eb6c
revert temporary view change
mikealfare May 13, 2024
66a600b
Merge branch 'main' into bug/1033-incremental-python-model
mikealfare May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements.txt
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with build requirements in setup.py with all extras, i.e. pip install .[all]

Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
pyhive[hive_pure_sasl]~=0.7.0
requests>=2.28.1

pyodbc~=5.0.1
pyodbc~=4.0.39
sqlparams>=3.0.0
thrift>=0.13.0
pyspark>=3.0.0,<4.0.0
sqlparse>=0.4.2 # not directly required, pinned by Snyk to avoid a vulnerability

types-PyYAML
Expand Down
7 changes: 0 additions & 7 deletions tests/functional/adapter/test_python_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,6 @@ class TestPythonIncrementalModelSpark(BasePythonIncrementalTests):
def project_config_update(self):
return {}

@pytest.mark.skip(
"Databricks can't find the transaction log"
"See https://github.com/dbt-labs/dbt-spark/issues/1033"
)
def test_incremental(self, project):
super().test_incremental(project)


models__simple_python_model = """
import pandas
Expand Down
Loading