Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit check for dbt-core #1015

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Add pre-commit check for dbt-core #1015

merged 1 commit into from
Apr 19, 2024

Conversation

mikealfare
Copy link
Contributor

See dbt-labs/dbt-adapters#144

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 19, 2024
@mikealfare mikealfare self-assigned this Apr 19, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 19, 2024
@mikealfare mikealfare linked an issue Apr 19, 2024 that may be closed by this pull request
[Feature] Linting/pre-commit check on dbt-core as a dependency dbt-labs/dbt-adapters#144
Closed
3 tasks
@mikealfare
Copy link
Contributor Author

The failing tests are known failing tests, pre-commit changes would not affect them. Merging despite the failing tests.

@mikealfare mikealfare merged commit 080ba71 into main Apr 19, 2024
38 of 41 checks passed
@mikealfare mikealfare deleted the add-dbt-core-check branch April 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Linting/pre-commit check on dbt-core as a dependency
2 participants
@mikealfare @colin-rogers-dbt