Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker release to the full release process for final releases #1004

Merged
merged 30 commits into from
May 21, 2024
Merged

Add docker release to the full release process for final releases #1004

merged 30 commits into from
May 21, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 5, 2024 •
edited
Loading

Problem

Publishing a Docker release is currently a manual process which can be forgotten.

Solution

Add the Docker release to the release pipeline.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare marked this pull request as draft April 5, 2024 22:55
@cla-bot cla-bot bot added the cla:yes label Apr 5, 2024
@mikealfare mikealfare self-assigned this Apr 5, 2024
@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Apr 5, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 2H 5M 1L 1I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 2H 5M 1L 1I
Secrets 0🔑

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-spark contributing guide.

@mikealfare mikealfare mentioned this pull request Apr 5, 2024
Closed
3 tasks
@mikealfare mikealfare linked an issue Apr 10, 2024 that may be closed by this pull request
[Feature] Automate Docker Release dbt-labs/dbt-release#109
Closed
3 tasks
@mikealfare mikealfare marked this pull request as ready for review April 13, 2024 06:05
mikealfare
mikealfare commented Apr 13, 2024
View reviewed changes
docker-dev/Dockerfile Outdated Show resolved Hide resolved
mikealfare
mikealfare commented Apr 13, 2024
View reviewed changes
docker-release/Dockerfile Outdated Show resolved Hide resolved
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 15, 2024
@mikealfare mikealfare marked this pull request as draft April 16, 2024 14:39
@mikealfare
Copy link
Contributor Author

Converting to draft until the broken test is resolved

emmyoop
emmyoop reviewed Apr 24, 2024
View reviewed changes
docker-release/Dockerfile Outdated Show resolved Hide resolved
mikealfare
mikealfare commented May 2, 2024
View reviewed changes
docker/Dockerfile
@@ -1,30 +1,42 @@
ARG OPENJDK_VERSION=8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this moved whole cloth to spark.Dockerfile.

@mikealfare
Copy link
Contributor Author

mikealfare commented May 3, 2024 •
edited
Loading

Test release against this branch:
https://github.com/dbt-labs/dbt-spark/actions/runs/9086969639

This successfully built a Docker image, but did not push it since it was a test run.

@mikealfare mikealfare marked this pull request as ready for review May 15, 2024 01:39
@mikealfare mikealfare requested a review from a team as a code owner May 15, 2024 01:39
VersusFacit
VersusFacit reviewed May 20, 2024
View reviewed changes
docker/test.sh Outdated Show resolved Hide resolved
@mikealfare mikealfare merged commit 944dbea into main May 21, 2024
20 checks passed
@mikealfare mikealfare deleted the config/docker-release branch May 21, 2024 04:57
@mikealfare mikealfare linked an issue Jun 10, 2024 that may be closed by this pull request
[ADAP-1071] [Bug] latest and 1.x.latest tags for ghcr Docker releases are stale #957
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop left review comments

@VersusFacit VersusFacit VersusFacit approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
3 participants
@mikealfare @emmyoop @VersusFacit