Parametrizing application name for more flexibility #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Everyone, is there any update on this PR? @dbeatty10 , @mikealfare please let me know if this is acknowledged. |
|
Closing per #148 (comment). |
1 similar comment
|
Closing per #148 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #148
Problem
As per the current implementation, the application name is hard coded to "dbt". But as per some use cases, it might require some custom application name.
Solution
Making the application name parametrized. Whatever value the user will pass as application in profiles.yml that will be considered as application name, if user doesn't pass any value then it will be hard coded to "dbt".
Checklist