Speedup catalog string comparison by using ilike before equals #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
reviewed
Apr 23, 2024
colin-rogers-dbt
approved these changes
May 13, 2024
colin-rogers-dbt
added
backport 1.7.latest
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Speedup catalog string comparison by using ilike before equals * Add parens * add changie * Update Under the Hood-20240425-144556.yaml (cherry picked from commit 32b6d39)
github-actions bot
pushed a commit
that referenced
this pull request
May 13, 2024
* Speedup catalog string comparison by using ilike before equals * Add parens * add changie * Update Under the Hood-20240425-144556.yaml (cherry picked from commit 32b6d39)
This was referenced May 13, 2024
2 tasks
colin-rogers-dbt
pushed a commit
that referenced
this pull request
May 14, 2024
…#1036) * Speedup catalog string comparison by using ilike before equals * Add parens * add changie * Update Under the Hood-20240425-144556.yaml (cherry picked from commit 32b6d39) Co-authored-by: Kshitij Aranke <[email protected]>
colin-rogers-dbt
added a commit
that referenced
this pull request
May 15, 2024
…#1037) * Speedup catalog string comparison by using ilike before equals * Add parens * add changie * Update Under the Hood-20240425-144556.yaml (cherry picked from commit 32b6d39) Co-authored-by: Kshitij Aranke <[email protected]> Co-authored-by: Colin Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1035
Problem
dbt docs generatefor a single model takes 30-90sSolution
Speed up
information_schemacomparison usingiliketo drop performance down to 3-4s.Checklist