Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop adding aliases to render_limited output #980

Merged
merged 8 commits into from
Apr 22, 2024
Merged

Stop adding aliases to render_limited output #980

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb6b2fb
add test
colin-rogers-dbt Apr 17, 2024
0170ce0
Merge branch 'main' into fixInlineSourceRefWithEmpty
colin-rogers-dbt Apr 17, 2024
5bed1c4
add changie
colin-rogers-dbt Apr 18, 2024
911e0f2
add changie
colin-rogers-dbt Apr 18, 2024
b6575f3
fix unit test import
colin-rogers-dbt Apr 18, 2024
2f3cbba
Merge branch 'main' into fixInlineSourceRefWithEmpty
colin-rogers-dbt Apr 19, 2024
79215e6
remove branch pointer from dev-requirements.txt
colin-rogers-dbt Apr 22, 2024
e0ff738
Merge remote-tracking branch 'origin/fixInlineSourceRefWithEmpty' int…
colin-rogers-dbt Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240418-160240.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Fix duplicate alias being added when running a model with inline refs and `--empty`
time: 2024-04-18T16:02:40.488967-07:00
custom:
Author: colin-rogers-dbt
Issue: "980"
2 changes: 1 addition & 1 deletion dbt/adapters/snowflake/relation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
class SnowflakeRelation(BaseRelation):
type: Optional[SnowflakeRelationType] = None # type: ignore
quote_policy: SnowflakeQuotePolicy = field(default_factory=lambda: SnowflakeQuotePolicy())

require_alias: bool = False
renameable_relations: FrozenSet[SnowflakeRelationType] = field(
default_factory=lambda: frozenset(
{
Expand Down
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-adapters.git
git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-adapters.git@makeAliasingOptional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to point back to main before merging

git+https://github.com/dbt-labs/dbt-adapters.git@makeAliasingOptional#subdirectory=dbt-tests-adapter

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
6 changes: 5 additions & 1 deletion tests/functional/adapter/empty/test_empty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
from dbt.tests.adapter.empty.test_empty import BaseTestEmpty
from dbt.tests.adapter.empty.test_empty import BaseTestEmpty, BaseTestEmptyInlineSourceRef


class TestSnowflakeEmpty(BaseTestEmpty):
pass


class TestSnowflakeEmptyInlineSourceRef(BaseTestEmptyInlineSourceRef):
pass
Loading