Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker automation tweak #978

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Docker automation tweak #978

merged 4 commits into from
Apr 24, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 17, 2024

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Nightly tests don't have sufficient permissions now that Docker releases have been added
Additionally, Docker released fail on a draft release since the tag does not exist.

Solution

Add the package: write permission to the nightly release
Do not release to Docker when we are running the release as a test
Allow the release to only release to Docker when a flag is flipped. This will allow us to release to Docker as needed if the final release already exists.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop requested a review from mikealfare April 17, 2024 12:41
@cla-bot cla-bot bot added the cla:yes label Apr 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Apr 17, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@emmyoop emmyoop merged commit 1e1def6 into main Apr 24, 2024
29 checks passed
@emmyoop emmyoop deleted the er/tweak-docker-release branch April 24, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants