Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker release to the full release process #963

Merged
merged 33 commits into from
Apr 15, 2024
Merged

Add docker release to the full release process #963

merged 33 commits into from
Apr 15, 2024

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Apr 3, 2024 •
edited
Loading

Problem

Publishing a Docker release is currently a manual process which can be forgotten.

Solution

Add the Docker release to the release pipeline.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Apr 3, 2024
@cla-bot cla-bot bot added the cla:yes label Apr 3, 2024
@mikealfare mikealfare requested a review from emmyoop April 3, 2024 03:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@wiz-inc-266a8a9c32
Copy link

wiz-inc-266a8a9c32 bot commented Apr 3, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 2H 1M 0L 1I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 2H 1M 0L 1I
Secrets 0🔑

@emmyoop emmyoop mentioned this pull request Apr 5, 2024
Closed
3 tasks
@mikealfare mikealfare linked an issue Apr 10, 2024 that may be closed by this pull request
[Feature] Automate Docker Release dbt-labs/dbt-release#109
Closed
3 tasks
emmyoop
emmyoop requested changes Apr 11, 2024
View reviewed changes
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@mikealfare mikealfare requested a review from emmyoop April 11, 2024 19:28
@mikealfare
Copy link
Contributor Author

This successfully published Docker here.

@mikealfare mikealfare changed the title Add docker release to the full release process for final releases Add docker release to the full release process Apr 12, 2024
@mikealfare
Copy link
Contributor Author

Still publishes successfully: https://github.com/dbt-labs/dbt-snowflake/pkgs/container/dbt-snowflake/203198363?tag=1.8.0b2

@mikealfare mikealfare enabled auto-merge (squash) April 15, 2024 21:33
@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Apr 15, 2024
@mikealfare mikealfare merged commit 8b75a53 into main Apr 15, 2024
33 of 34 checks passed
@mikealfare mikealfare deleted the config/docker-release branch April 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

Assignees

@mikealfare mikealfare

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Automate Docker Release
2 participants
@mikealfare @emmyoop