Test incremental model with unique key both as string and list #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VersusFacit
force-pushed
the
CT-129/add_incremental_unique_id_test
branch
2 times, most recently
from
e96e7ff to
b09dc94
Compare
VersusFacit
force-pushed
the
CT-129/add_incremental_unique_id_test
branch
from
b09dc94 to
d345426
Compare
Merged
4 tasks
|
Aaaannd all systems green 🚀 ready once more for review |
VersusFacit
changed the title
kwigley
reviewed
Feb 21, 2022
kwigley
reviewed
Feb 21, 2022
tests/integration/incremental_unique_id_test/test_incremental_unique_id.py
Outdated
Show resolved
Hide resolved
ChenyuLInx
reviewed
Feb 21, 2022
tests/integration/incremental_unique_id_test/test_incremental_unique_id.py
Outdated
Show resolved
Hide resolved
tests/integration/incremental_unique_id_test/test_incremental_unique_id.py
Outdated
Show resolved
Hide resolved
tests/integration/incremental_unique_id_test/test_incremental_unique_id.py
Outdated
Show resolved
Hide resolved
tests/integration/incremental_unique_id_test/test_incremental_unique_id.py
Show resolved
Hide resolved
leahwicz
reviewed
Feb 22, 2022
Revised the test for failures to be more accurate and performed a bit of renaming. I also folded two methods into setup that didn't need their own level of abstraction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91
Adds tests to this adapter for unique key changes in PR 4618 in dbt-core.
Description
Adds three classes to mirror the branching paths (unique_key as string, list, both). I tried not to duplicate tests already found in dbt-core. Where possible, I followed existing conventions (e.g. using expected SQL models for comparison). There's a ton of side effects by virtue of model building, but I've attempted to keep things readable by separating out steps into functions.
To help, I've added intention based documentation where possible, but feel free to request more!
I've written a set of tests that not only covers several ways to specify
unique_keybut also simulates real-world incremental update behavior. In doing so, these tests ensure model build and uniqueness semantics are carried out. I mocked up examples in a jaffle_shop first since incremental behavior is a bit wonky at first.Because incremental model behavior requires multiple runs to display, I opted for actual model files as opposed to queries in code.
edit: Sorry for the force pushes. I had to tease out last minute an error due to mission
unique_keyin an integration test. It was passing locally but here until I got the parameters just right. Just one of those bugs! Should be reliably resolved though. And then this PR fell prey to the Jinja dependency failure. Integration tests are passing locally.Ps: I have also been requested to create documentation for Leona to update community docs and am midway through its production. I've already met with @runleonarun synchronously and showed her a lot of the new featureset added. Would be happy to share this with the team.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-snowflake next" section.