Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish internal build workflow #945

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Finish internal build workflow #945

Changes from 3 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
27e9cdf
Add workflow for snowflake and changelog
VersusFacit Mar 18, 2024
6d82093
Merge branch 'main' into add_release_internal_workflow
VersusFacit Mar 21, 2024
303fd24
Add comments and make fit conventions.
VersusFacit Mar 21, 2024
71add79
Add changelog.
VersusFacit Mar 21, 2024
d14126a
reorder input params
VersusFacit Mar 21, 2024
3f82faa
Tweaks to input params.
VersusFacit Mar 21, 2024
92b44f5
Add quotes
VersusFacit Mar 21, 2024
fe6bffa
Add build to valid semver.
VersusFacit Mar 21, 2024
25d4189
Change python version to match Cloud.
VersusFacit Mar 22, 2024
0df1cc3
Finalize workflow.
VersusFacit Mar 26, 2024
8a95469
Merge branch 'main' into add_release_internal_workflow
VersusFacit Mar 26, 2024
c09b7f8
Change branch reference of workflow to main.
VersusFacit Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 18 additions & 26 deletions .github/workflows/release-internal.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,15 @@
# What?
#
# Tag and release an arbitrary sha. Uploads to an internal archive for further processing.
#
# How?
#
# After checking out and testing the provided sha, the image is built and uploaded.
#
# When?
#
# Manual trigger.

name: Release internal patch

on:
Expand All @@ -21,26 +33,6 @@ on:
type: string
default: "snowflake"
required: true
workflow_call:
inputs:
version_number:
description: "The release version number (i.e. 1.0.0b1)"
type: string
required: true
sha:
description: "The sha to use (leave empty to use latest on main)"
type: string
required: false
package_test_command:
description: "Package test command"
type: string
default: "python -c \"import dbt.adapters.snowflake\""
required: true
dbms_name:
description: "The name of the warehouse the adapter connects to."
type: string
default: "snowflake"
required: true

defaults:
run:
Expand All @@ -51,14 +43,14 @@ env:

jobs:
invoke-reusable-workflow:
name: Build and Release Internally
name: "Build and Release Internally"

uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to change this once main has all the changes needed to support all the other workflows. Since this PR's workflow can be invoked using the branch reference, I'll merge at the time I can revert to main (unless there is an alternate path desired)


with:
version_number: ${{ inputs.version_number }}
package_test_command: ${{ inputs.package_test_command }}
dbms_name: ${{ inputs.dbms_name }}
sha: ${{ inputs.sha }}
version_number: "${{ inputs.version_number }}"
package_test_command: "${{ inputs.package_test_command }}"
dbms_name: "${{ inputs.dbms_name }}"
sha: "${{ inputs.sha }}"

secrets: inherit
Loading