Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update dynamic table metadata queryies to take into account new object type. #937

Merged
merged 66 commits into from
Mar 20, 2024

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 19, 2024

resolves #934
docs dbt-labs/docs.getdbt.com/#

Problem

Snowflake gave dynamic tables a object type of BASE TABLE when it was null now we need to modify our SQL queries to build out the tables based.

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Mar 19, 2024
@cla-bot cla-bot bot added the cla:yes label Mar 19, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 requested a review from mikealfare March 20, 2024 20:52
@McKnight-42 McKnight-42 marked this pull request as ready for review March 20, 2024 21:21
@mikealfare mikealfare merged commit 95ca3bf into main Mar 20, 2024
25 checks passed
@mikealfare mikealfare deleted the mcknight/fix-dynamic-tables branch March 20, 2024 21:26
@McKnight-42 McKnight-42 added the backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch label Mar 20, 2024
github-actions bot pushed a commit that referenced this pull request Mar 20, 2024
… object type. (#937)

* initial push to fix dynamic tables now that they have BASE TABLE as object type
* update to is_dnyamic expected value
* take into account uppercase

(cherry picked from commit 95ca3bf)
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-937-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 95ca3bf61e5a7172e4991be4e678c4d84faec9b0
# Push it to GitHub
git push --set-upstream origin backport-937-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-937-to-1.6.latest.

Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-937-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 95ca3bf61e5a7172e4991be4e678c4d84faec9b0
# Push it to GitHub
git push --set-upstream origin backport-937-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-937-to-1.6.latest.

mikealfare pushed a commit that referenced this pull request Mar 21, 2024
… object type. (#937) (#941)

* initial push to fix dynamic tables now that they have BASE TABLE as object type
* update to is_dnyamic expected value
* take into account uppercase

(cherry picked from commit 95ca3bf)

Co-authored-by: Matthew McKnight <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch cla:yes
Projects
None yet
2 participants