Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove token from _connection_keys #906

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Conversation

colin-rogers-dbt
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Feb 16, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@colin-rogers-dbt colin-rogers-dbt self-assigned this Feb 16, 2024
@colin-rogers-dbt colin-rogers-dbt marked this pull request as ready for review February 16, 2024 21:05
@colin-rogers-dbt colin-rogers-dbt requested a review from a team as a code owner February 16, 2024 21:05
@colin-rogers-dbt colin-rogers-dbt merged commit 2c0b16f into main Feb 16, 2024
14 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the removeTokenFromConnKeys branch February 16, 2024 21:06
@colin-rogers-dbt colin-rogers-dbt added backport 1.5.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Feb 16, 2024
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-906-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c0b16f73f5c56fbc5ec9c278f3716f09473c416
# Push it to GitHub
git push --set-upstream origin backport-906-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-906-to-1.5.latest.

github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
* remove token from _connection_keys

* add changie

* remove token from _connection_keys

(cherry picked from commit 2c0b16f)
github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
* remove token from _connection_keys

* add changie

* remove token from _connection_keys

(cherry picked from commit 2c0b16f)
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-906-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c0b16f73f5c56fbc5ec9c278f3716f09473c416
# Push it to GitHub
git push --set-upstream origin backport-906-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-906-to-1.5.latest.

@colin-rogers-dbt colin-rogers-dbt added backport 1.5.latest and removed backport 1.5.latest backport 1.7.latest Tag for PR to be backported to the 1.7.latest branch labels Feb 16, 2024
Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-906-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c0b16f73f5c56fbc5ec9c278f3716f09473c416
# Push it to GitHub
git push --set-upstream origin backport-906-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-906-to-1.5.latest.

martynydbt pushed a commit that referenced this pull request Feb 16, 2024
* remove token from _connection_keys

* add changie

* remove token from _connection_keys

(cherry picked from commit 2c0b16f)

Co-authored-by: colin-rogers-dbt <[email protected]>
martynydbt pushed a commit that referenced this pull request Feb 16, 2024
* remove token from _connection_keys

* add changie

* remove token from _connection_keys

(cherry picked from commit 2c0b16f)

Co-authored-by: colin-rogers-dbt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants