-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upticking cryptography to address 41.0.5 security vulnerability. #852
Upticking cryptography to address 41.0.5 security vulnerability. #852
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
9f43e67
to
6fdcb88
Compare
6fdcb88
to
43ac4dd
Compare
I noticed you skipped the changelog. I think we have a type for security fixes. Is there a reason to not use that? How far back do we need to backport this? |
@mikealfare oop! Glad you pointed out the changelog. I'm still coming to our current state of affairs process-wise. Added changelog! As for how far to backport, not sure. Does it make sense to cover each of the versions we host in Cloud? So the last 4 inclusive? 1.7, 1.6, 1.5, 1.4? |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-852-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b75f26a7243dc69d3f16a75620e2fb79bfd1bf9a
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-852-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b75f26a7243dc69d3f16a75620e2fb79bfd1bf9a
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-852-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b75f26a7243dc69d3f16a75620e2fb79bfd1bf9a
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-852-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b75f26a7243dc69d3f16a75620e2fb79bfd1bf9a
# Push it to GitHub
git push --set-upstream origin backport-852-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
resolves #845
Problem
DDOS vulnerability. Timely fix.
Solution
Uptick it past 41.0.5.
Checklist