Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move configuration out of workflows and eliminate tox as a dependency #838

Closed
wants to merge 6 commits into from

Conversation

mikealfare
Copy link
Contributor

Problem

There's configuration in both the config files and in the GHA workflows. We use tox on top of this to manage some of the configuration.

Solution

  • Move configuration out of GHA workflows and into config files, prioritizing pyproject.toml
  • Move configuration out of tox and into config files, prioritizing pyproject.toml
  • Remove tox as a requirement

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 21, 2023
@cla-bot cla-bot bot added the cla:yes label Nov 21, 2023
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare
Copy link
Contributor Author

This will happen as part of the migration to dbt-adapters

@mikealfare mikealfare closed this Jan 16, 2024
@mikealfare mikealfare deleted the devops/workflow-configs branch January 16, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant