-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test against 1.7.latest release branch and fix semve #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-rogers-dbt
approved these changes
Oct 9, 2023
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
* update RELEASE_BRANCH env * test semver in 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
Currently nightly release tests fail since core does not view the supplied adapter version as valid semver:
dbt.exceptions.SemverError: "1.5.6.dev10092023" is not a valid semantic version.
This change would have "dev" be a build tag instead of a patch version, so the new version be: 1.5.6+dev10092023
resolves #
Solution
reassign part of semvar to tag to be able to read it properly
dbt-snowflake version of this fix dbt-labs/dbt-bigquery#961
Checklist