Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-893: Support test results as views #783

Merged
merged 9 commits into from
Oct 11, 2023
Merged

ADAP-893: Support test results as views #783

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5c62e87
implement persist test results tests, leave querying relation type as…
mikealfare Sep 19, 2023
07ae3c5
update to use centralized relation type tests
mikealfare Sep 21, 2023
7a5875b
update changelog and test names to reflect renamed parameter
mikealfare Sep 29, 2023
b8223fa
Merge branch 'main' into feature/materialized-tests/adap-893
mikealfare Sep 29, 2023
e026442
implement store-failures-as test cases
mikealfare Oct 3, 2023
2a3d37d
revert dev branch update
mikealfare Oct 10, 2023
e2ec25a
update tests to cover new test cases in dbt-core
mikealfare Oct 10, 2023
d9afa6b
Merge branch 'main' into feature/materialized-tests/adap-893
mikealfare Oct 10, 2023
5c00a52
Merge branch 'main' into feature/materialized-tests/adap-893
mikealfare Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Features-20230919-171047.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Features
body: Support storing test failures as views
time: 2023-09-19T17:10:47.516098-04:00
custom:
Author: mikealfare
Issue: "6914"
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# install latest changes in dbt-core
# TODO: how to automate switching from develop to version branches?
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter
git+https://github.com/dbt-labs/dbt-core.git@feature/materialized-tests/adap-850#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git@feature/materialized-tests/adap-850#egg=dbt-tests-adapter&subdirectory=tests/adapter

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
Expand Down
24 changes: 23 additions & 1 deletion tests/functional/adapter/store_test_failures_tests/test_store_test_failures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,29 @@
from dbt.tests.adapter.store_test_failures_tests.basic import (
StoreTestFailuresAsGeneric,
StoreTestFailuresAsInteractions,
StoreTestFailuresAsProjectLevelOff,
StoreTestFailuresAsProjectLevelView,
)
from dbt.tests.adapter.store_test_failures_tests.test_store_test_failures import (
TestStoreTestFailures,
)


class SnowflakeTestStoreTestFailures(TestStoreTestFailures):
class TestSnowflakeStoreTestFailures(TestStoreTestFailures):
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
pass


class TestSnowflakeStoreTestFailuresAsInteractions(StoreTestFailuresAsInteractions):
pass


class TestSnowflakeStoreTestFailuresAsProjectLevelOff(StoreTestFailuresAsProjectLevelOff):
pass


class TestSnowflakeStoreTestFailuresAsProjectLevelView(StoreTestFailuresAsProjectLevelView):
pass


class TestSnowflakeStoreTestFailuresAsGeneric(StoreTestFailuresAsGeneric):
pass