ADAP-865: Parameterize where clause, add option to supply list of relations #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
mikealfare
commented
Aug 29, 2023
mikealfare
commented
Aug 29, 2023
mikealfare
commented
Aug 29, 2023
This comment was marked as outdated.
This comment was marked as outdated.
mikealfare
changed the title
mikealfare
commented
Sep 13, 2023
…on logic with get_catalog_relations
… of relations temporarily for testing
…eRelation] version
dbeatty10
reviewed
Oct 5, 2023
graciegoheen
reviewed
Oct 6, 2023
|
@mikealfare do you predict that there will be relevant adapter zone tests here? |
The idea is that once this feature gets turned on (which it is for @colin-rogers-dbt, I know you had the same question. Does this address your concern as well? |
McKnight-42
approved these changes
Oct 11, 2023
philippe-boyd-maxa
pushed a commit
to maxa-ai/dbt-snowflake
that referenced
this pull request
Nov 27, 2023
…ations (dbt-labs#758) * parameterize where clause, add option to supply list of relations * parameterize where clause, add option to supply list of relations * revert whitespace fix * revert whitespace fix * revert whitespace fix * fix missing macro keyword * point to the dev branch on core, revert before pushing to main * add new macro get_catalog_relations, update get_catalog to share common logic with get_catalog_relations * fixed reference in get_catalog_relations, added original dict version of relations temporarily for testing * remove dict version of relations based get_catalog, point to List[BaseRelation] version * point dev reqs back to main on core * fix typo in schemas argument * add feature flag to turn on relation filtering for get_catalog * update changelog to point to the PR instead of a broken url * Support changes to dbt-core capability system --------- Co-authored-by: Peter Allen Webb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #801
docs dbt-labs/docs.getdbt.com/#
Problem
The current implementation of
get_catalogonly supports schema-level limitation. This can take a long time when schemas have a lot of objects in them.Solution
Provide a way to pass in a list of relations instead of schemas. The new
relationsparameter can be a list of relations, a list of schema relation objects, or a mix.Checklist