Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand init prompts in template #729

Closed
wants to merge 7 commits into from

Conversation

gwenwindflower
Copy link

resolves #728

Problem

Prompts were very terse and didn't display great in the CLI.

Solution

Made 'em more verbose.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gwenwindflower gwenwindflower requested a review from a team as a code owner August 9, 2023 12:16
@cla-bot cla-bot bot added the cla:yes label Aug 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

Copy link
Contributor

@mikealfare mikealfare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, and then we would need a changie entry as well. I think I would call this Under the Hood?

dbt/include/snowflake/profile_template.yml Outdated Show resolved Hide resolved
dbt/include/snowflake/profile_template.yml Outdated Show resolved Hide resolved
@dbeatty10
Copy link
Contributor

I left a few comments, and then we would need a changie entry as well. I think I would call this Under the Hood?

@gwenwindflower here's the instructions to create an changelog entry:

  1. Follow the steps to install changie for your system.
  2. changie new
    • Fill out the answers
    • It will spit out a .yml file at the end
  3. Commit and push that .yml file. I typically use a simple commit message like "Changelog entry".

@mikealfare mikealfare marked this pull request as draft September 1, 2023 22:45
@dbeatty10 dbeatty10 changed the base branch from main to 1.7.latest January 8, 2024 19:22
@dbeatty10 dbeatty10 changed the base branch from 1.7.latest to main January 8, 2024 19:23
@mikealfare
Copy link
Contributor

In order to avoid some extra work, we're going to wait until the adapter/core decoupling work is done, and then update this PR with those changes (should be virtually nothing) before merging in.

@dbeatty10 dbeatty10 self-assigned this Jan 22, 2024
Copy link
Contributor

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 21, 2024
@dbeatty10 dbeatty10 removed the Stale label Jul 22, 2024
@mikealfare mikealfare closed this Nov 9, 2024
@mikealfare mikealfare deleted the gw/feature/improved-init-prompts branch November 9, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-786] Hints for dbt init auto-profile completion don't display in as helpful a way as they could
3 participants