Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Conversion for Query Tag Tests #235

Merged
merged 8 commits into from
Aug 23, 2022
Merged

Test Conversion for Query Tag Tests #235

merged 8 commits into from
Aug 23, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Aug 15, 2022 •
edited
Loading

Description

snowflake specific pytest conversion of integration test query_tag_tests to new format.

TODO:

  • Run python script
  • Reformat as needed
  • test locally
  • delete old test

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@McKnight-42 McKnight-42 self-assigned this Aug 15, 2022
@cla-bot cla-bot bot added the cla:yes label Aug 15, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@McKnight-42 McKnight-42 requested a review from ChenyuLInx August 15, 2022 20:12
@McKnight-42
require prefix fixture from project.py passing on views, failing on i…
476e07b 
…ncremental and tables currently during build
@McKnight-42 McKnight-42 requested a review from ChenyuLInx August 16, 2022 15:31
@McKnight-42
Copy link
Contributor Author

tagging this pr to keep track on it #210 so we can update tests all at once.

ChenyuLInx
ChenyuLInx approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@McKnight-42 McKnight-42 added Skip Changelog Skips GHA to check for changelog file and removed Skip Changelog Skips GHA to check for changelog file labels Aug 23, 2022
@McKnight-42 McKnight-42 merged commit 0b4868d into main Aug 23, 2022
@McKnight-42 McKnight-42 deleted the mcknight/convert_query_tag branch August 23, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@emmyoop emmyoop emmyoop approved these changes

@gshank gshank Awaiting requested review from gshank

@VersusFacit VersusFacit Awaiting requested review from VersusFacit

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @emmyoop @ChenyuLInx