Fix refresh_strategy = auto semantics for dynamic tables #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
…rategy (implicit or explicit).
colin-rogers-dbt
approved these changes
Dec 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Add failing test. * Parametrize cases * Change comparison logic for when to rebuild if DT has auto refresh strategy (implicit or explicit). * Add changelog --------- Co-authored-by: VersusFacit <[email protected]> (cherry picked from commit b3eeb08)
colin-rogers-dbt
added a commit
that referenced
this pull request
Dec 9, 2024
* Add failing test. * Parametrize cases * Change comparison logic for when to rebuild if DT has auto refresh strategy (implicit or explicit). * Add changelog --------- Co-authored-by: VersusFacit <[email protected]> (cherry picked from commit b3eeb08) Co-authored-by: Mila Page <[email protected]> Co-authored-by: Colin Rogers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1267
docs dbt-labs/docs.getdbt.com/#
Problem
We were treating
AUTOas a metadata value but it's actually a runtime directive value.autodispatches intoincrementalorfull, so we need to compare accordingly.Solution
Fix the boolean to never rebuild for an
automodelChecklist