-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] use new model.batch context vars #1258
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
1 similar comment
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one concern about the new pattern 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
(cherry picked from commit 457c361)
(cherry picked from commit 457c361) Co-authored-by: Michelle Ark <[email protected]>
resolves #1263
docs dbt-labs/docs.getdbt.com/#
Problem
With the introduction of the new batch context variable in dbt-core==1.9.0rc2, it is recommended to use batch.event_time_start and batch.event_time_end over node.config.__dbt_internal.* variables.
Solution
copy+replace, with safe access of
model.batch
propertyChecklist