Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev branch dependencies from dev requirements #1237

Closed
wants to merge 2 commits into from

Conversation

mikealfare
Copy link
Contributor

Problem

We were pulling in dbt-adapters from main on GH and made a breaking change.

Solution

Since 1.8 is a final release, we should not be pulling from dev branches for tests. Remove all dbt dependencies from GitHub. Leave dbt-tests-adapter but pull it from PyPI.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Nov 8, 2024
@cla-bot cla-bot bot added the cla:yes label Nov 8, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@cla-bot cla-bot bot added the cla:yes label Nov 8, 2024
@mikealfare
Copy link
Contributor Author

We are going to update the unit tests instead.

@mikealfare mikealfare closed this Nov 8, 2024
@mikealfare mikealfare deleted the fix-query-id-unit-tests branch November 9, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant