Fix Dynamic Iceberg Table Required DDL Params #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take optional off params that are not optional in dynamic table create DDL.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide. |
VersusFacit
changed the title
VersusFacit
commented
Oct 8, 2024
dbt/include/snowflake/macros/relations/dynamic_table/create.sql
Outdated
Show resolved
Hide resolved
VersusFacit
force-pushed
the
ADAP-1200/fix_base_location_ddl_for_dynamic_iceberg_tables
branch
from
3984329 to
40c33e3
Compare
mikealfare
approved these changes
Oct 8, 2024
| @@ -0,0 +1,6 @@ | |||
| kind: Fixes | |||
| body: Dynamic Iceberg table DDL catalog parameter fixes. | |||
There was a problem hiding this comment.
I would consider making this changelog entry specific to base_location_subpath.
VersusFacit
deleted the
ADAP-1200/fix_base_location_ddl_for_dynamic_iceberg_tables
branch
seediang
pushed a commit
to seediang/dbt-snowflake
that referenced
this pull request
Oct 12, 2024
* Fix base location not rendering without subpath and add tests. Take optional off params that are not optional in dynamic table create DDL. * Add changelog. * Revert changes to external volume * revert changes to catalog optionality. * Tabs. * Fix base_location_subpath generation for dynamic tables. --------- Co-authored-by: VersusFacit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1200
Problem
Base location isn't generating a default value.
Solution
Render the base location explicitly.
Checklist