Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adap 321/support all on schema change options #1195

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

VersusFacit
Copy link
Contributor

related to fully supporting #321

Problem

alter statements in incremental strategies need the table format.

Solution

Thankfully, we were well set up to leverage our existing relation abstractions to make these work out of box.

scenarios hand-tested:

  • sync_all_columns:
    • add column
    • remove a column
    • add and remove a column
  • append_new_columns:
    • add columns
    • don't delete columns that no longer are in DDL

✅ These changes only apply to incremental-run affected columns

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit requested a review from a team as a code owner September 30, 2024 18:24
@cla-bot cla-bot bot added the cla:yes label Sep 30, 2024
@VersusFacit VersusFacit self-assigned this Sep 30, 2024
@mikealfare mikealfare merged commit f60c476 into main Sep 30, 2024
25 checks passed
@mikealfare mikealfare deleted the ADAP-321/support_all_on_schema_change_options branch September 30, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants