Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning to v1.3.2 allows all tests to pass #1150

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

McKnight-42
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

needing to pin dbt-adapters and dbt-tests-adapter to fix tests

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 self-assigned this Jul 25, 2024
@cla-bot cla-bot bot added the cla:yes label Jul 25, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Jul 25, 2024
@McKnight-42
Copy link
Contributor Author

both commits passed for me locally either by pinning based on tag for dbt-adapters and dbt-tests-adapter or by removing the 1.8.latest pin for dbt-core.

which do we think makes more sense as a team?

@colin-rogers-dbt colin-rogers-dbt merged commit c280877 into 1.8.latest Jul 29, 2024
29 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the mcknight/pin_dbt_adapters_repos branch July 29, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants