Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
refresh_mode
andinitialize
as dynamic table options #1081Add
refresh_mode
andinitialize
as dynamic table options #1081Changes from 16 commits
7ba40c9
17eb974
c92522e
addaa63
932a58f
13dc7de
6076e3a
1c2f222
c2905cc
f44ebf6
761a991
c2bf2b3
08ddd42
405420f
8606770
c7781a4
99ba501
3db741b
657d498
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the
RelationConfig
allows us to easily incorporate input validation forrefresh_mode
andinitialize
. If we're doing that, we should pull all attribution from this class, hence updatingtarget_lag
andsnowflake_warehouse
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as for
snowflake__get_create_dyanmic_table_sql
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now handled via the
initialize
parameter. Sinceinitialize
defaults toON_CREATE
, this is consistent with the current behavior.