Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to see if pre_model_hook works for tests around snowflake_warehouse #1070

Merged
merged 13 commits into from
Jun 14, 2024
Merged

Add tests to see if pre_model_hook works for tests around snowflake_warehouse #1070

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c4f89cc
init attempt of adding logger.info for model_hooks
McKnight-42 Jun 4, 2024
9d50d06
modify logging to not post full config (unnessecary on every run)
McKnight-42 Jun 4, 2024
c45b801
init form of test added
McKnight-42 Jun 5, 2024
b7c647e
change core pointer in dev-requirements
McKnight-42 Jun 5, 2024
b254a50
update to main
McKnight-42 Jun 6, 2024
0185022
removing logging as unneeded per feedback, and adding assert to new test
McKnight-42 Jun 6, 2024
ae16ab7
add in passing test
McKnight-42 Jun 10, 2024
305bf77
add in passing test
McKnight-42 Jun 10, 2024
98974e2
Merge branch 'main' of https://github.com/dbt-labs/dbt-snowflake into…
McKnight-42 Jun 12, 2024
9533012
consolidate sql fixtures
McKnight-42 Jun 12, 2024
52716e0
Merge branch 'main' of https://github.com/dbt-labs/dbt-snowflake into…
McKnight-42 Jun 13, 2024
3f37148
revert core pointer
McKnight-42 Jun 13, 2024
e6b9ae4
remove unneeded quote
McKnight-42 Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# install latest changes in dbt-core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
# install latest changes in dbt-core"
git+https://github.com/dbt-labs/dbt-core.git@mcknight/10198#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-adapters.git
McKnight-42 marked this conversation as resolved.
Show resolved Hide resolved
git+https://github.com/dbt-labs/dbt-adapters.git#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git
Expand Down
32 changes: 27 additions & 5 deletions tests/functional/warehouse_test/test_warehouses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,34 @@

import os


models__override_warehouse_sql = """
{{ config(snowflake_warehouse=env_var('SNOWFLAKE_TEST_ALT_WAREHOUSE', 'DBT_TEST_ALT'), materialized='table') }}
select current_warehouse() as warehouse

"""

models__expected_warehouse_sql = """
{{ config(materialized='table') }}
select '{{ env_var("SNOWFLAKE_TEST_ALT_WAREHOUSE", "DBT_TEST_ALT") }}' as warehouse

"""

models__invalid_warehouse_sql = """
{{ config(snowflake_warehouse='DBT_TEST_DOES_NOT_EXIST') }}
select current_warehouse() as warehouse

"""

project_config_models__override_warehouse_sql = """
{{ config(materialized='table') }}
select current_warehouse() as warehouse

"""

project_config_models__expected_warehouse_sql = """
{{ config(materialized='table') }}
select '{{ env_var("SNOWFLAKE_TEST_ALT_WAREHOUSE", "DBT_TEST_ALT") }}' as warehouse
"""

project_config_models__invalid_warehouse_sql = """
{{ config(materialized='table') }}
select current_warehouse() as warehouse
"""


Expand Down Expand Up @@ -90,3 +89,26 @@ def test_snowflake_override_ok(self, project):
]
)
check_relations_equal(project.adapter, ["OVERRIDE_WAREHOUSE", "EXPECTED_WAREHOUSE"])


class TestInvalidConfigWarehouse:
@pytest.fixture(scope="class")
def models(self):
return {
"invalid_warehouse.sql": project_config_models__invalid_warehouse_sql,
}

@pytest.fixture(scope="class")
def project_config_update(self):
return {
"config-version": 2,
"models": {
"test": {
"snowflake_warehouse": "DBT_TEST_DOES_NOT_EXIST",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nicely done - we should expect the dbt test to try using a Snowflake warehouse that doesn't exist (use warehouse DBT_TEST_DOES_NOT_EXIST), where previously it wouldn't, and so it should fail with Object does not exist, or operation cannot be performed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went ahead and also added a assert to catch if that error message stops showing up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of completeness, can we add a positive test case that uses this config option, just to make sure it's setting it? The error message we're getting in the negative test case is pretty general.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a new test

},
},
}

def test_snowflake_override_invalid(self, project):
result = run_dbt(["run", "--models", "invalid_warehouse"], expect_pass=False)
assert "Object does not exist, or operation cannot be performed" in result[0].message
Loading