Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Prefix secrets with DBT_ENV_SECRET_ for test env vars" #1012

Merged
merged 1 commit into from
May 1, 2024

Conversation

mikealfare
Copy link
Contributor

Reverts #995

This didn't work for the release workflows, which make stricter assumptions on environment variables. This is being reverted while we discuss a more thorough approach.

@mikealfare mikealfare self-assigned this May 1, 2024
@cla-bot cla-bot bot added the cla:yes label May 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-snowflake contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label May 1, 2024
@mikealfare
Copy link
Contributor Author

Since this is a workflow change, CI needs to run using the workflow on this branch. Here's the run: https://github.com/dbt-labs/dbt-snowflake/actions/runs/8916286219

@mikealfare mikealfare merged commit a6c6e5e into main May 1, 2024
46 of 49 checks passed
@mikealfare mikealfare deleted the revert-995-add-secrets-prefix-to-env-vars branch May 1, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants