Skip to content

Commit

Permalink
skipping a test till we decide how to best handle new truth around ve…
Browse files Browse the repository at this point in the history
…rsion expectation (#976)

* update RELEASE_BRANCH env

* skipping a test due to changes around how dbt_package version and dbt installed version are not always the same anymore

* add changelog

* update pytset.skip to pytest.mark.skip

---------

Co-authored-by: colin-rogers-dbt <[email protected]>
  • Loading branch information
McKnight-42 and colin-rogers-dbt authored Apr 17, 2024
1 parent 3b014a8 commit 0ed1a29
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240416-203625.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: skipping a test that provides a false condition
time: 2024-04-16T20:36:25.449409-05:00
custom:
Author: McKnight-42
Issue: "976"
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import pytest
from dbt.tests.adapter.query_comment.test_query_comment import (
BaseQueryComments,
BaseMacroQueryComments,
Expand All @@ -17,7 +18,12 @@ class TestMacroQueryCommentsSnowflake(BaseMacroQueryComments):


class TestMacroArgsQueryCommentsSnowflake(BaseMacroArgsQueryComments):
pass
@pytest.mark.skip(
"This test is incorrectly comparing the version of `dbt-core`"
"to the version of `dbt-snowflake`, which is not always the same."
)
def test_matches_comment(self, project, get_package_version):
pass


class TestMacroInvalidQueryCommentsSnowflake(BaseMacroInvalidQueryComments):
Expand Down

0 comments on commit 0ed1a29

Please sign in to comment.