Use Caching in Github Actions Workflow #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
plypaul--04--cache-python
branch
12 times, most recently
from
df45d22 to
4ea6c01
Compare
plypaul
changed the title
plypaul
force-pushed
the
plypaul--04--cache-python
branch
2 times, most recently
from
b8e2422 to
0bc9eec
Compare
plypaul
force-pushed
the
plypaul--04--cache-python
branch
4 times, most recently
from
cfc9929 to
7775f41
Compare
QMalcolm
approved these changes
Feb 9, 2024
tlento
reviewed
Feb 15, 2024
Comment on lines
8
to
6
| pydantic-version: | ||
| description: "Version of Pydantic to use for testing" | ||
| required: true |
There was a problem hiding this comment.
If you set a default of 1.10 on this I think you can revert most of the non-caching updates in this PR, since I've separately consolidated actions into this setup.
Alternatively, we can use this as an annotation defaulted to "none" just to seed the cache key and then only install Pydantic in the calling action where it's required. That'll eliminate nearly all of the action-level changes in this PR. If we go that route we should probably name the key something like installed-pydantic-version or suchlike.
|
My delays in merging approved PRs have come to bite me. |
plypaul
force-pushed
the
plypaul--04--cache-python
branch
from
7775f41 to
f79c8c0
Compare
|
FYI - this reduces the Python test action from 90-120s -> 30-40s. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets up the caching action in the Github workflow so that installing Python dependencies is faster.
Checklist
changie newto create a changelog entry